fix: arch discovery

refactor repository steps following official docker installation steps

meta/runtime.yml

@@ -1,2 +0,0 @@
----
-requires_ansible: ">=2.15.0"

roles/base/tasks/main.yml

@@ -35,3 +35,5 @@
 #       APT::Periodic::Unattended-Upgrade "1";
 #     mode: "0644"
 #   when: ansible_facts['os_family'] == "Debian"
+
+## SCHEDULE REBOOTS 4 kernel upgrades: with cron, unattended-upgrades or action workflows?

roles/docker/tasks/main.yml

@@ -1,76 +1,82 @@
 ---
-- name: Install Docker
+- name: Install Docker prerequisites
+  ansible.builtin.apt:
+    name:
+      - ca-certificates
+      - curl
+    state: present
+    update_cache: true
   become: true
-  block:
-    - name: Install Docker prerequisites
-      ansible.builtin.apt:
-        name:
-          - ca-certificates
-          - curl
-          - python3-debian ## needed for the deb822 module
-        state: present
-        update_cache: true
 
-    - name: Add Docker official APT repository (DEB822 format)
+- name: Ensure APT keyrings directory exists
-      ansible.builtin.deb822_repository:
+  ansible.builtin.file:
-        name: docker
+    path: /etc/apt/keyrings
-        types: deb
+    state: directory
-        uris: "https://download.docker.com/linux/{{ ansible_facts['distribution'] | lower }}"
+    mode: "0755"
-        suites: "{{ ansible_facts['distribution_release'] }}"
-        components: stable
-        signed_by: "https://download.docker.com/linux/{{ ansible_facts['distribution'] | lower }}/gpg"
-        state: present
-
-    - name: Install Docker CE packages
-      ansible.builtin.apt:
-        name:
-          - docker-ce
-          - docker-ce-cli
-          - containerd.io
-          - docker-buildx-plugin
-          - docker-compose-plugin
-        state: present
-        update_cache: true
-
-    - name: Ensure Docker service is running and enabled
-      ansible.builtin.service:
-        name: docker
-        state: started
-        enabled: true
-
-- name: Configure deployment user for Docker
-  when: deployment_public_ssh_key is defined
   become: true
-  block:
-    - name: Add deployment user to docker group
-      ansible.builtin.user:
-        name: deployment
-        groups: docker
-        append: true
 
-    - name: Create target for docker compose
+- name: Download Docker official GPG key
-      ansible.builtin.file:
+  ansible.builtin.get_url:
-        path: /opt/docker
+    url: "https://download.docker.com/linux/{{ ansible_distribution | lower }}/gpg"
-        state: directory
+    dest: /etc/apt/keyrings/docker.asc
-        owner: deployment
+    mode: "0644"
-        group: deployment
-        mode: "0755"
-
-- name: Create app user for secure container execution
   become: true
-  block:
-    - name: Create appuser group
-      ansible.builtin.group:
-        name: appuser
-        state: present
-        gid: 9999
 
-    - name: Create appuser
+- name: Get system architecture
-      ansible.builtin.user:
+  ansible.builtin.command: dpkg --print-architecture
-        name: appuser
+  register: dpkg_architecture
-        state: present
+  changed_when: false
-        uid: 9999
+  become: true
-        group: appuser
+
-        system: true
+- name: Add Docker official APT repository
-        shell: /usr/sbin/nologin
+  ansible.builtin.apt_repository:
-        create_home: false
+    repo: "deb [arch={{ dpkg_architecture.stdout }} signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/{{ ansible_distribution | lower }} {{ ansible_distribution_release }} stable"
+    state: present
+    filename: docker
+    update_cache: yes
+  become: true
+
+- name: Install modern Docker CE packages
+  ansible.builtin.apt:
+    name:
+      - docker-ce
+      - docker-ce-cli
+      - containerd.io
+      - docker-buildx-plugin
+      - docker-compose-plugin
+    state: present
+  become: true
+
+- name: Ensure Docker services are running and enabled
+  ansible.builtin.service:
+    name: docker
+    state: started
+    enabled: true
+  become: true
+
+- name: Create docker user for container execution
+  ansible.builtin.user:
+    name: docker
+    state: present
+    system: true
+    shell: /usr/sbin/nologin
+    groups: docker
+    append: true
+    create_home: false
+  become: true
+
+- name: Add deployment user to docker group
+  ansible.builtin.user:
+    name: deployment
+    groups: docker
+    append: true
+  become: true
+
+- name: Create target for docker compose
+  ansible.builtin.file:
+    path: /opt/docker
+    state: directory
+    owner: deployment
+    group: deployment
+    mode: "0755"
+  become: true

roles/security/tasks/main.yml

@@ -1,35 +1,33 @@
 ---
-- name: Harden SSH configuration
+- name: Create SSH drop-in directory
+  ansible.builtin.file:
+    path: /etc/ssh/sshd_config.d
+    state: directory
+    owner: root
+    group: root
+    mode: "0755"
   become: true
-  block:
-    - name: Create SSH drop-in directory
-      ansible.builtin.file:
-        path: /etc/ssh/sshd_config.d
-        state: directory
-        owner: root
-        group: root
-        mode: "0755"
 
-    - name: Harden SSH configuration with drop-in template
+- name: Harden SSH configuration with drop-in template
-      ansible.builtin.template:
+  ansible.builtin.template:
-        src: sshd.conf.j2
+    src: sshd.conf.j2
-        dest: /etc/ssh/sshd_config.d/sshd.conf
+    dest: /etc/ssh/sshd_config.d/sshd.conf
-        owner: root
+    owner: root
-        group: root
+    group: root
-        mode: "0644"
+    mode: "0644"
-      notify: Restart sshd
+    validate: "sshd -t -f %s"
-
+  notify: Restart sshd
-- name: Enable fail2ban
   become: true
-  block:
-    - name: Install fail2ban
-      ansible.builtin.apt:
-        name:
-          - fail2ban
-        state: present
 
-    - name: Start fail2ban
+- name: Install fail2ban
-      ansible.builtin.service:
+  ansible.builtin.apt:
-        name: fail2ban
+    name:
-        state: started
+      - fail2ban
-        enabled: yes
+    state: present
+  become: true
+
+- name: Start fail2ban
+  ansible.builtin.service:
+    name: fail2ban
+    state: started
+    enabled: yes

roles/users/tasks/main.yml

@@ -1,42 +1,38 @@
 ---
-- name: Set up primary sysadmin user
+# - name: Create primary admin user
-  when: sysadmin_public_ssh_key is defined
+#   ansible.builtin.user:
+#     name: sysadmin
+#     groups: sudo
+#     append: yes
+#     shell: /bin/bash
+#     create_home: yes
+#   become: true
+
+# - name: Add SSH public key for sysadmin
+#   ansible.posix.authorized_key:
+#     user: sysadmin
+#     state: present
+#     key: "{{ sysadmin_public_ssh_key }}"
+#   become: true
+
+# - name: Allow passwordless sudo to sysadmin user
+#   ansible.builtin.copy:
+#     dest: /etc/sudoers.d/sysadmin
+#     content: "sysadmin ALL=(ALL) NOPASSWD: ALL"
+#     mode: "0440"
+#     validate: /usr/sbin/visudo -cf %s
+#   become: true
+
+- name: Create deployment user for CI/CD
+  ansible.builtin.user:
+    name: deployment
+    shell: /bin/bash
+    create_home: yes
   become: true
-  block:
-    - name: Create sysadmin user
-      ansible.builtin.user:
-        name: "{{ sysadmin_user }}"
-        groups: sudo
-        append: yes
-        shell: /bin/bash
-        create_home: yes
 
-    - name: Add SSH public key
+- name: Add SSH public key for deployment user
-      ansible.posix.authorized_key:
+  ansible.posix.authorized_key:
-        user: "{{ sysadmin_user }}"
+    user: deployment
-        state: present
+    state: present
-        key: "{{ sysadmin_public_ssh_key }}"
+    key: "{{ deployment_public_ssh_key }}"
-
-    - name: Allow passwordless sudo
-      ansible.builtin.copy:
-        dest: /etc/sudoers.d/sudo-nopasswd
-        content: "%sudo ALL=(ALL) NOPASSWD: ALL"
-        mode: "0440"
-        validate: /usr/sbin/visudo -cf %s
-
-
-- name: Set up deployment user for CI/CD
-  when: deployment_public_ssh_key is defined
   become: true
-  block:
-    - name: Create deployment user
-      ansible.builtin.user:
-        name: deployment
-        shell: /bin/bash
-        create_home: yes
-
-    - name: Add SSH public key
-      ansible.posix.authorized_key:
-        user: deployment
-        state: present
-        key: "{{ deployment_public_ssh_key }}"